This repository has been archived by the owner on Dec 13, 2024. It is now read-only.
Use GetExtensionEvents to derive extension event numbers #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GetExtensionEvents JVMTI spec: https://download.java.net/java/early_access/jdk19/docs/specs/jvmti.html#GetExtensionEvents Ports: |
babsingh
force-pushed
the
fix_exteventnumbers
branch
2 times, most recently
from
d7e2fa8 to
0de19f1
Compare
This was referenced Feb 1, 2023
|
@keithc-ca Can you please review/merge this PR and other ports mentioned in #65 (comment)? |
Yes, but starting with the head stream: ibmruntimes/openj9-openjdk-jdk#545. |
|
Please mirror here the changes made to ibmruntimes/openj9-openjdk-jdk#545. |
Currently, extension event numbers are hard-coded in the tests. This is invalid since the extension event numbers can vary between implementations. Instead, GetExtensionEvents should be used to derive the extension event numbers. Related: eclipse-openj9/openj9#16501 Related: eclipse-openj9/openj9#16167 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
force-pushed
the
fix_exteventnumbers
branch
from
0de19f1 to
36f8d4f
Compare
Completed. |
|
Jenkins test sanity zlinux jdk19 |
keithc-ca
approved these changes
Feb 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, extension event numbers are hard-coded in the tests. This is
invalid since the extension event numbers can vary between
implementations. Instead, GetExtensionEvents should be used to derive
the extension event numbers.
Related: eclipse-openj9/openj9#16501
Related: eclipse-openj9/openj9#16167
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com