This repository has been archived by the owner on Dec 13, 2024. It is now read-only.
[FFI]Inline the missing libc functions for symbol lookup on AIX #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR is verified with the FFI specific test suites in OpenJ9 and the Jtreg test suite |
pshipton
reviewed
Mar 3, 2023
src/java.base/share/classes/jdk/internal/foreign/SystemLookup.java
Outdated
Show resolved
Hide resolved
The changes aim to support the symbol lookup via FFI for the missing libc functions in loading the default library on AIX by inlining their address into a function list in native to ensure they are correctly invoked with the native address fetched in the FFI code. Fixes: #eclipse-openj9/openj9/issues/16386 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
ffi_inline_libc_func_jdk19
branch
from
13e21dc to
f1526bb
Compare
|
jenkins compile aix jdk19 |
|
Pls port this to the other versions as well. |
PRs are created at ibmruntimes/openj9-openjdk-jdk20#22 & ibmruntimes/openj9-openjdk-jdk#557. |
pshipton
added a commit
to pshipton/openjdk-tests
that referenced
this pull request
Mar 4, 2023
Fixed via ibmruntimes/openj9-openjdk-jdk19#75 ibmruntimes/openj9-openjdk-jdk20#22 ibmruntimes/openj9-openjdk-jdk#557 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
Grinder running java/foreign/StdLibTest.java passed. Opened adoptium/aqa-tests#4388 to unexclude the test. |
pshipton
approved these changes
Mar 4, 2023
|
#76 will add this to the 0.37 release branch. |
pshipton
added a commit
to pshipton/openjdk-tests
that referenced
this pull request
Mar 4, 2023
Fixed via ibmruntimes/openj9-openjdk-jdk19#75 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
sophia-guo
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Mar 4, 2023
Fixed via ibmruntimes/openj9-openjdk-jdk19#75 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes aim to support the symbol lookup via FFI for
the missing libc functions in loading the default library on
AIX by inlining their address into a function list in native to
ensure they are correctly invoked with the native address
fetched in the FFI code.
Fixes: #eclipse-openj9/openj9/issues/16386
Signed-off-by: ChengJin01 jincheng@ca.ibm.com