Allow RestrictedSecurity property extension from default values #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default values existing in the java.security file are now considered the baseline and all profiles can inherit them and add or remove to them, if they are in list form. This does not include the providers, though. Signed-off-by: Kostas Tsiounis<kostas.tsiounis@ibm.com>
|
FYI @keithc-ca |
|
Jenkins test sanity amac jdk23 |
keithc-ca
approved these changes
Oct 4, 2024
keithc-ca
reviewed
Oct 4, 2024
| @@ -185,25 +185,14 @@ RestrictedSecurity.NSS.140-2.securerandom.algorithm = PKCS11 | |||
| RestrictedSecurity.OpenJCEPlusFIPS.FIPS140-3.desc.name = OpenJCEPlusFIPS Cryptographic Module FIPS 140-3 | |||
| RestrictedSecurity.OpenJCEPlusFIPS.FIPS140-3.desc.default = false | |||
| RestrictedSecurity.OpenJCEPlusFIPS.FIPS140-3.desc.fips = true | |||
| RestrictedSecurity.OpenJCEPlusFIPS.FIPS140-3.desc.hash = SHA256:4a85dc0db2f257388155b3ada7378773884edc89c80c8d715f4bdde84cc3d8bd | |||
| RestrictedSecurity.OpenJCEPlusFIPS.FIPS140-3.desc.hash = SHA256:bea1b7da967ac27720b7bc439ccd2d4250ebe783a6919a8e7047e6a6b862a116 | |||
There was a problem hiding this comment.
I think this hash should be 9970c0538b11f34a779803337d213d6fc7ca13849361e0e52a997a5629ced508. Please create a follow-up change to correct that.
There was a problem hiding this comment.
I actually built with the changes and tested it and the hash is the correct one.
There was a problem hiding this comment.
You are right, I ran a bad test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default values existing in the java.security file are now considered the baseline and all profiles can inherit them and add or remove to them, if they are in list form. This does not include the providers, though.
Back-ported from: ibmruntimes/openj9-openjdk-jdk#849
Signed-off-by: Kostas Tsiounis kostas.tsiounis@ibm.com