Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix I18n.load_path injection #546

Merged
merged 3 commits into from
May 30, 2024
Merged

fix I18n.load_path injection #546

merged 3 commits into from
May 30, 2024

Commits on May 28, 2024

  1. fix I18n.load_path injection 

    ice_cube would inject its locale files at the end of `I18n.load_path` due to its `IceCube::I18n` module being `autoload`ed and thereby overwrite any customisation the user may have made in other locale files earlier in the load path.

i fix this by injecting ice cube locales at gem load time so that the user has a chance to modify locale keys later.

this also eliminates a bunch of delegation having a custom I18n module; `IceCube::I18n` is just the same as ::I18n if the i18n gem is available.

resolves ice-cube-ruby#489, ice-cube-ruby#432, ice-cube-ruby#431
    @glaszig
    glaszig committed May 28, 2024
    Configuration menu
    Copy the full SHA
    2e596bc View commit details
    Browse the repository at this point in the history

  2. use __dir__ expansion instead of __FILE__

    @glaszig
    glaszig committed May 28, 2024
    Configuration menu
    Copy the full SHA
    9e19ce2 View commit details
    Browse the repository at this point in the history

  3. disable linter for I18n gymnastics

    @glaszig
    glaszig committed May 28, 2024
    Configuration menu
    Copy the full SHA
    08b429e View commit details
    Browse the repository at this point in the history