Skip to content

Commit

Permalink
fix(SQS): Log errors with SQS connections. Fixes argoproj#1114 (argop…
Browse files Browse the repository at this point in the history
…roj#1115)

* Add additional logging to expose errors when connecting to AWS SQS

Signed-off-by: Orion Delwaterman <delwaterman@gmail.com>

* Add Greenhouse as users

Signed-off-by: Orion Delwaterman <delwaterman@gmail.com>
  • Loading branch information
delwaterman authored Mar 15, 2021
1 parent ad2fb83 commit 1cc31c1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions USERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Organizations below are **officially** using Argo Events. Please send a PR with
1. [Canva](https://www.canva.com/)
1. [DevSamurai](https://www.devsamurai.com/)
1. [Fairwinds](https://fairwinds.com/)
1. [Greenhouse Software](https://www.greenhouse.io/)
1. [InsideBoard](https://www.insideboard.com)
1. [Intuit](https://www.intuit.com/)
1. [OneCause](https://www.onecause.com/)
Expand Down
2 changes: 2 additions & 0 deletions eventsources/sources/awssqs/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ func (el *EventListener) StartListening(ctx context.Context, dispatch func([]byt
var awsSession *session.Session
awsSession, err := awscommon.CreateAWSSessionWithCredsInVolume(sqsEventSource.Region, sqsEventSource.RoleARN, sqsEventSource.AccessKey, sqsEventSource.SecretKey)
if err != nil {
log.Errorw("Error creating AWS credentials", zap.Error(err))
return errors.Wrapf(err, "failed to create aws session for %s", el.GetEventName())
}

Expand All @@ -85,6 +86,7 @@ func (el *EventListener) StartListening(ctx context.Context, dispatch func([]byt

queueURL, err := sqsClient.GetQueueUrl(getQueueURLInput)
if err != nil {
log.Errorw("Error getting SQS Queue URL", zap.Error(err))
return errors.Wrapf(err, "failed to get the queue url for %s", el.GetEventName())
}

Expand Down

0 comments on commit 1cc31c1

Please sign in to comment.