fix(eventbus): allow clients with istio sidecar. Fixes: argoproj#1311 (…

…argoproj#1312)

Istio-related issues affecting this behaviour:

- nats-io/nats-operator#88
- istio/istio#28623

The fix is very simple. I added the related issues to the code comment,
let me know if that's undesirable or there's something else to clarify.

Signed-off-by: Antonio M. Macías Ojeda <antonio.macias.ojeda@gmail.com>

Co-authored-by: Derek Wang <whynowy@gmail.com>

controllers/eventbus/installer/nats.go

@@ -414,7 +414,11 @@ func (i *natsInstaller) buildStanService() (*corev1.Service, error) {
 		Spec: corev1.ServiceSpec{
 			ClusterIP: corev1.ClusterIPNone,
 			Ports: []corev1.ServicePort{
-				{Name: "client", Port: clientPort},
+				// Prefix tcp- to enable clients to connect from
+				// an istio-enabled namespace, following:
+				// https://github.com/nats-io/nats-operator/issues/88
+				// https://github.com/istio/istio/issues/28623
+				{Name: "tcp-client", Port: clientPort},
 				{Name: "cluster", Port: clusterPort},
 				{Name: "monitor", Port: monitorPort},
 			},