Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glow backend does not support Image #674

Closed
rednaz1337 opened this issue Dec 27, 2020 · 4 comments · Fixed by #1485
Closed

glow backend does not support Image #674

rednaz1337 opened this issue Dec 27, 2020 · 4 comments · Fixed by #1485
Labels
feature New feature or request image rendering

Comments

@rednaz1337
Copy link

Is it possible to run the tour example with the glow backend? when I add the glow feature to the example's Cargo.toml I get the following error:

error[E0277]: the trait bound `iced_glow::backend::Backend: iced_graphics::backend::Image` is not satisfied
   --> examples/tour/src/main.rs:675:5
    |
675 |     Container::new(
    |     ^^^^^^^^^^^^^^ the trait `iced_graphics::backend::Image` is not implemented for `iced_glow::backend::Backend`
    |
    = note: required because of the requirements on the impl of `iced_native::widget::image::Renderer` for `iced_graphics::renderer::Renderer<iced_glow::backend::Backend>`
    = note: required because of the requirements on the impl of `From<Image>` for `iced_native::element::Element<'_, _, iced_graphics::renderer::Renderer<iced_glow::backend::Backend>>`
    = note: required because of the requirements on the impl of `Into<iced_native::element::Element<'_, _, iced_graphics::renderer::Renderer<iced_glow::backend::Backend>>>` for `Image`
    = note: required by `iced_native::widget::container::Container::<'a, Message, Renderer>::new`

It seems like the Image widget is not supported on the glow backend.

@cryptoquick
Copy link

Yeah, it looks like there's no iced_glow/image implementation, like there is for iced_wgpu/image.

@cryptoquick
Copy link

Related to #354

@hecrj hecrj added the feature New feature or request label Jan 24, 2021
@gennyble
Copy link

gennyble commented Feb 9, 2021

Probably not the right place to ask, but is anyone working on Image for iced_glow? I'd very much like it to be a thing and would be happy to give Image a glow if someone isn't already working on it.

@hecrj hecrj changed the title Tour example with glow backend Image support for glow backend Jan 20, 2022
@hecrj
Copy link
Member

hecrj commented Jan 20, 2022

The current Image implementation has a bunch of underlying issues!

Instead of porting the existing code to the glow backend, we should focus on coming up with a proper implementation that addresses most of these issues.

@hecrj hecrj changed the title Image support for glow backend glow backend does not support Image Jan 20, 2022
ids1024 added a commit to ids1024/iced that referenced this issue Oct 25, 2022
iced-rs#674

This works, but duplicates code from `iced_wgpu` that should ideally be
shared, and the cache never evicts.

The next step here is to work on an API design to move some of the image
loading and caching logic from the backend to `iced_graphics` (or
elsewhere?).
ids1024 added a commit to ids1024/iced that referenced this issue Oct 25, 2022
iced-rs#674

This works, but duplicates code from `iced_wgpu` that should ideally be
shared, and the cache never evicts.

The next step here is to work on an API design to move some of the image
loading and caching logic from the backend to `iced_graphics` (or
elsewhere?).
ids1024 added a commit to ids1024/iced that referenced this issue Oct 25, 2022
iced-rs#674

This works, but duplicates code from `iced_wgpu` that should ideally be
shared, and the cache never evicts.

The next step here is to work on an API design to move some of the image
loading and caching logic from the backend to `iced_graphics` (or
elsewhere?).
ids1024 added a commit to ids1024/iced that referenced this issue Oct 25, 2022
iced-rs#674

This works, but duplicates code from `iced_wgpu` that should ideally be
shared, and the cache never evicts.

The next step here is to work on an API design to move some of the image
loading and caching logic from the backend to `iced_graphics` (or
elsewhere?).
ids1024 added a commit to ids1024/iced that referenced this issue Nov 4, 2022
iced-rs#674

Uses image/svg support in `iced_graphics`. The is not currently using an
atlas, and uses one texture/draw per image. This should be good enough
for now; supporting images with glow is better than not supporting them,
and if something else performs better, that improvement can be made
without any change to the public API.
ids1024 added a commit to ids1024/iced that referenced this issue Nov 4, 2022
iced-rs#674

Uses image/svg support in `iced_graphics`. The is not currently using an
atlas, and uses one texture/draw per image. This should be good enough
for now; supporting images with glow is better than not supporting them,
and if something else performs better, that improvement can be made
without any change to the public API.
ids1024 added a commit to ids1024/iced that referenced this issue Nov 4, 2022
iced-rs#674

Uses image/svg support in `iced_graphics`. The is not currently using an
atlas, and uses one texture/draw per image. This should be good enough
for now; supporting images with glow is better than not supporting them,
and if something else performs better, that improvement can be made
without any change to the public API.
hecrj pushed a commit to ids1024/iced that referenced this issue Nov 5, 2022
iced-rs#674

Uses image/svg support in `iced_graphics`. The is not currently using an
atlas, and uses one texture/draw per image. This should be good enough
for now; supporting images with glow is better than not supporting them,
and if something else performs better, that improvement can be made
without any change to the public API.
derezzedex pushed a commit to derezzedex/iced_opengl that referenced this issue May 12, 2023
iced-rs/iced#674

Uses image/svg support in `iced_graphics`. The is not currently using an
atlas, and uses one texture/draw per image. This should be good enough
for now; supporting images with glow is better than not supporting them,
and if something else performs better, that improvement can be made
without any change to the public API.
derezzedex pushed a commit to derezzedex/iced_opengl that referenced this issue May 12, 2023
iced-rs/iced#674

Uses image/svg support in `iced_graphics`. The is not currently using an
atlas, and uses one texture/draw per image. This should be good enough
for now; supporting images with glow is better than not supporting them,
and if something else performs better, that improvement can be made
without any change to the public API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request image rendering
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants