Add wgpu custom rendering example #1003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvilim
commented
Aug 20, 2021
| ) -> (Primitive, mouse::Interaction) { | ||
| // We update the current bounds of this custom widget, so that the custom rendering | ||
| // step will render it in the correct spot | ||
| self.bounds.replace(layout.bounds()); |
There was a problem hiding this comment.
Although the full example is pretty long, this is the key point, where the layout is extracted to locate the custom render pass.
hecrj
force-pushed
the
master
branch
2 times, most recently
from
e6ab610 to
8b0f2e6
Compare
|
While using a completely new render pass on top of the GUI can work for most cases, I don't think we should officially recommend it since it can easily break overlays. For this reason, I think it's best to wait until a proper 3D widget lands (see #343)! |
|
Okay, no problem! Thanks for taking the time to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wgpu custom rendered widget example
Hi! I am returning to #903, and I realized that the existing
layoutinformation is sufficient to appropriately locate a custom render pass with the rest of the UI. I have put together this PR with an example that demonstrates a custom rendered widget.This solution is effectively option 4 from #903; it's just that necessary information was already mostly exposed. It's a bit hacky, since it captures the contents of the
layoutargument to the widgetdrawcall. It's only possible in projects that directly integrate withwgpu(such as theintegration_wgpuexample, from which my example is derived), and such projects already want to have fine control over their rendering.Despite its slight hackiness, this seems like a perfectly sufficient solution for my use case. Do you think this example is worth including in the repo? If the overall approach is appropriate, but the particular method of extracting the
layoutfrom thedrawcall is too hacky, then perhaps I can instead make some extensions toicedso that thelayoutof a given widget can be queried.