Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally allow mainline winit for external integration purposes #1189

Closed
wants to merge 2 commits into from

Conversation

tasgon
Copy link

@tasgon tasgon commented Jan 10, 2022

I'd like to integrate iced UI rendering in other projects, however the usage of the forked winit can break some dependency handling. I've made it so that users can toggle between it and the mainline version through a feature (defaulting to the forked version).

@hecrj
Copy link
Member

hecrj commented Jan 10, 2022

Since the changes to winit and glutin are experimental and relatively minor, I recently pushed a new 0.4 branch which uses the official winit and glutin releases. I will try to frequently backport all the changes to master there!

Instead of allowing for dynamic switching of dependencies in master, I believe most users should simply rely on this new branch. Would that work for you?

@tasgon
Copy link
Author

tasgon commented Jan 10, 2022

Just tested your branch, and it seems to work for me. Out of curiosity, are you planning on publishing this version? If it wouldn't be too much of a burden, would it be possible to have versions of this crate in sync with new versions of wgpu and winit on crates.io? If you'd like, I can assist with the updating process as necessary.

@hecrj
Copy link
Member

hecrj commented Jan 10, 2022

Yes, I have plans to publish 0.4 soon. But before that, I'd like to have the new website ready and the "Architecture" chapters of the book finished.

At that point, it'll be just a matter of coming up with a proper announcement with a nice change log. A lot has happened since the last release!

I'd appreciate any help on these fronts!

@hecrj hecrj closed this Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants