Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent pane grid title bar content and controls from overlapping #1361

Merged

Conversation

mtkennerly
Copy link
Contributor

This fixes the content/controls becoming unreadable when they overlap in narrow panes.

Should this be configurable? For example:

enum Overlap {
    Allow, // existing behavior
    HideContent, // proposed behavior
    HideControls,
}

Before

before.mp4

After

after.mp4

Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! It's definitely better than displaying overlapping elements.

Maybe we could make it configurable in a different PR? Your idea seems great.

Thank you 🙇

@hecrj hecrj added feature New feature or request widget layout labels Jun 17, 2022
@hecrj hecrj added this to the 0.4.3 milestone Jun 17, 2022
@hecrj hecrj merged commit 092dfc3 into iced-rs:master Jun 23, 2022
@hecrj hecrj modified the milestones: 0.4.3, 0.5.0 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request layout widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants