Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update wgpu to 0.13 #1378

Merged
merged 9 commits into from
Jul 3, 2022
Merged

update wgpu to 0.13 #1378

merged 9 commits into from
Jul 3, 2022

Conversation

Cupnfish
Copy link
Contributor

@Cupnfish Cupnfish commented Jul 2, 2022

No description provided.

Cupnfish
Cupnfish commented Jul 2, 2022
View reviewed changes
wgpu/Cargo.toml Outdated
wgpu = "0.12"
wgpu_glyph = "0.16"
wgpu = "0.13"
wgpu_glyph = { version = "0.16", git = "https://github.com/Cupnfish/wgpu_glyph.git", branch = "wgpu-0.13" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting to merge this: hecrj/wgpu_glyph#89

hecrj
hecrj reviewed Jul 2, 2022
View reviewed changes
wgpu/Cargo.toml Outdated Show resolved Hide resolved
hecrj
hecrj reviewed Jul 2, 2022
View reviewed changes
examples/integration_wgpu/src/main.rs

local_pool.run_until_stalled();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more local pool! That's great 😄

@hecrj hecrj added improvement An internal improvement feature New feature or request rendering wgpu labels Jul 2, 2022
@hecrj hecrj added this to the 0.5.0 milestone Jul 2, 2022
PolyMeilex
PolyMeilex suggested changes Jul 2, 2022
View reviewed changes
wgpu/src/shader/image.wgsl Outdated Show resolved Hide resolved
@PolyMeilex
Copy link
Contributor

Also, ; after struct defs is no longer needed (rust like syntax), but that's just a purely stylistic choice. I'm just noting that switching to that syntax is now possible.

hecrj
hecrj approved these changes Jul 3, 2022
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some small changes here and there, but everything looks great! Thanks for taking care of this so quickly 🙇

Also very glad to see all of the wgpu improvements! 🎉

PolyMeilex
PolyMeilex approved these changes Jul 3, 2022
View reviewed changes
Copy link
Contributor

@PolyMeilex PolyMeilex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments from me, looks good to me as well.

@hecrj hecrj merged commit 66eb626 into iced-rs:master Jul 3, 2022
@hecrj hecrj mentioned this pull request Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

@PolyMeilex PolyMeilex PolyMeilex approved these changes

Assignees
No one assigned
Labels
feature New feature or request improvement An internal improvement rendering wgpu
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Cupnfish @PolyMeilex @hecrj