Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine glow_default_system_font and default_system_font features #1505

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

ids1024
Copy link
Contributor

@ids1024 ids1024 commented Nov 3, 2022

Apparently "weak dependency features" have been stable since Rust 1.60.0, allowing a feature to enable a feature of a dependency only if that dependency is enabled elsewhere. So having a separate feature for this with glow is unnecessary now.

Also remove the resolver setting which is redundant on edition 2021.

Apparently "weak dependency features" have been stable since Rust
1.60.0, allowing a feature to enable a feature of a dependency only if
that dependency is enabled elsewhere. So having a separate feature for
this with glow is unnecessary now.

Also remove the `resolver` setting which is redundant on edition 2021.
@hecrj hecrj added improvement An internal improvement developer experience labels Nov 8, 2022
@hecrj hecrj added this to the 0.5.0 milestone Nov 8, 2022
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels good when your tools keep getting better consistently. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants