Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non uniform border radius for quads #1506

Merged
merged 8 commits into from
Dec 2, 2022

Conversation

rksm
Copy link
Contributor

@rksm rksm commented Nov 3, 2022

This allows quads to be rendered with different border radius values. It only modifies quads, not yet any widgets based on that. I tried to open a discussion about the implications of changing the API of widgets such as button over here but didn't receive any feedback.

non-uniform-quad-example

A project showing the use of that can be found over here: https://github.com/rksm/iced-non-uniform-border-radius.

@rksm
Copy link
Contributor Author

rksm commented Nov 4, 2022

This feature is quite useful to for example render more sophisticated buttons. It's similar to the CSS border-radius property.

image

Happy to address potential concerns.

@hecrj hecrj added this to the 0.5.0 milestone Nov 8, 2022
@hecrj hecrj force-pushed the non-uniform-border-radius-for-quads branch from 3875a46 to 15f2164 Compare November 8, 2022 03:54
@hecrj hecrj modified the milestones: 0.5.0, 0.6.0 Nov 8, 2022
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! 🥳 Thank you.

I have added your custom_quad as an official example as well.

@hecrj hecrj merged commit 91d5516 into iced-rs:master Dec 2, 2022
@rksm
Copy link
Contributor Author

rksm commented Dec 2, 2022

Thanks for adding this! Stoked to see how much development is happening around iced!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants