#1484, #1527: Fix overlay transition #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
approved these changes
Nov 13, 2022
There was a problem hiding this comment.
Thanks for taking a look!
This bug has been alive for a while. Basically, the issue is that the active overlay may change after an Event in the base layer is processed. Reusing the layout of the old overlay is incorrect in that case!
Your initial fix consisted in always invalidating the cache of the overlay layout. I changed it in bbd55ff so we only invalidate when an Event in the base layer is Captured, which I believe is reasonable.
Hopefully this still works!
Looks good on my end :D Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1484 and #1527, at least on my system (Windows 11).
I just figured it seemed like the old overlay was being held onto, and so I tried to find where it might need to be flushed. This works, but I haven't studied the other
user_interfacecode to see how this aligns with the rest of the design, so I don't know if it's a good/correct solution.I tested the
pick_listandtourexamples with this change. Here's a modifiedpick_listto show the new behavior: