Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Operations within PaneGrid #1533

Merged
merged 1 commit into from
Nov 13, 2022
Merged

Fixed Operations within PaneGrid #1533

merged 1 commit into from
Nov 13, 2022

Conversation

rs017991
Copy link
Contributor

Fixes #1532

@rs017991 rs017991 mentioned this pull request Nov 13, 2022
Closed
2 tasks
@hecrj hecrj added bug Something isn't working shell labels Nov 13, 2022
@hecrj hecrj added this to the 0.6.0 milestone Nov 13, 2022
@hecrj hecrj force-pushed the op_bug_fix_panegrid branch from f53692c to 5419180 Compare November 13, 2022 23:03
@rs017991
Copy link
Contributor Author

Oops, I missed a file when committing. Coming right up...

@hecrj hecrj force-pushed the op_bug_fix_panegrid branch from 5419180 to b0678f4 Compare November 13, 2022 23:09
@hecrj
Copy link
Member

hecrj commented Nov 13, 2022 •
edited
Loading

No worries! Just implemented the missing stuff myself :)

@rs017991
Copy link
Contributor Author

Ah, you beat me to it. Sorry about that

hecrj
hecrj approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! I had the feeling I missed some stuff here. Thanks for cathing it!

@hecrj hecrj merged commit 5f08b8d into iced-rs:master Nov 13, 2022
@rs017991 rs017991 deleted the op_bug_fix_panegrid branch November 13, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working shell
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Operations Broken in PaneGrid
2 participants
@rs017991 @hecrj