Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scissor layer bounds for images when using glow #1557

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

wash2
Copy link
Contributor

@wash2 wash2 commented Nov 23, 2022

This fixes an issue where images show up outside of the bounds of their parent, for example when in a scrollable.

@wash2 wash2 marked this pull request as draft November 23, 2022 19:20
@wash2
Copy link
Contributor Author

wash2 commented Nov 23, 2022

I think actually this fix needs a bit more testing and adjustment, so i've made it a draft.

@wash2 wash2 marked this pull request as ready for review November 23, 2022 19:47
@wash2 wash2 changed the title fix: scissor layout bounds for images when using glow fix: scissor layer bounds for images when using glow Nov 24, 2022
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks 🙇

@hecrj hecrj added the bug Something isn't working label Nov 29, 2022
@hecrj hecrj added this to the 0.6.0 milestone Nov 29, 2022
@hecrj hecrj merged commit 67420cb into iced-rs:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working image rendering widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants