Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement window::close action and remove should_exit #1606

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Implement window::close action and remove should_exit #1606

merged 1 commit into from
Dec 15, 2022

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Dec 15, 2022

Instead of returning true once in should_exit, simply return window::close() in your update whenever the application is ready to exit.

@hecrj hecrj added feature New feature or request shell labels Dec 15, 2022
@hecrj hecrj added this to the 0.7.0 milestone Dec 15, 2022
@hecrj hecrj merged commit d2d1847 into master Dec 15, 2022
@hecrj hecrj deleted the feature/window-close branch December 15, 2022 04:28
@sowbug sowbug mentioned this pull request Feb 3, 2023
Closed
black-puppydog added a commit to black-puppydog/pods that referenced this pull request Feb 10, 2023
@black-puppydog
Update iced back to crate
86d32a7 
Adapts to the removal of `should_close` in this PR:
iced-rs/iced#1606
black-puppydog added a commit to black-puppydog/pods that referenced this pull request Feb 10, 2023
@black-puppydog
Update iced back to crate
7fdb115 
Adapts to the removal of `should_close` in this PR:
iced-rs/iced#1606

# Conflicts:
#	gui/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New feature or request shell
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
1 participant
@hecrj