Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix doc links #1634

Merged
merged 1 commit into from
Jan 4, 2023
Merged

fix doc links #1634

merged 1 commit into from
Jan 4, 2023

Conversation

Araxeus
Copy link
Contributor

@Araxeus Araxeus commented Jan 3, 2023

one broken link prompted me to change all the 0.6 references to master

- //! [renderer-agnostic native runtime]: https://github.com/iced-rs/iced/0.4/master/native
+ //! [renderer-agnostic native runtime]: https://github.com/iced-rs/iced/tree/master/native

@hecrj hecrj added this to the 0.7.0 milestone Jan 4, 2023
@hecrj
Copy link
Member

hecrj commented Jan 4, 2023

master can contain breaking changes since the last release. We can't point to it from the API reference.

@hecrj hecrj closed this Jan 4, 2023
@Araxeus
Copy link
Contributor Author

Araxeus commented Jan 4, 2023

Would be cool if you didnt close the pr and just let me change it, I literally wrote that I opened it because of a broken link

@hecrj hecrj reopened this Jan 4, 2023
@hecrj
Copy link
Member

hecrj commented Jan 4, 2023

Would be cool if you didnt close the pr and just let me change it

Sure! If you prefer to rebase instead of opening a new PR, go ahead.

@Araxeus
Copy link
Contributor Author

Araxeus commented Jan 4, 2023

fixed it :)

hecrj
hecrj approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you 🥳

@hecrj hecrj merged commit e7f06af into iced-rs:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Araxeus @hecrj