-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide widgets IDs to Operation::container
#1695
Conversation
operation.container
Operation::container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could just get away with adding the id
to just the Container
widget?
I agree with this. Wrap whatever with a |
Sounds good, I cut this down to just the container 👍 |
This reverts commit 8f9550b.
5e33725
to
273c9be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I have rebased and dropped 63cfec6, since Scrollable
already has an Id
and it makes sense to provide it.
Use of
operation::scoped
requires a widget which provides its ID toOperation::container
. Currently none of the provided container widgets do this, so using scoped operations requires implementation of a custom widget. This PR adds the option to provide an ID to each container widget that doesn't have it already (button, container, row, column, pane grid) and provides this ID toOperation::container
inWidget::operate
.