Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pad after setting width in text input #1706

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Pad after setting width in text input #1706

merged 1 commit into from
Feb 15, 2023

Conversation

tarkah
Copy link
Member

@tarkah tarkah commented Feb 14, 2023

This fixes an issue where using Length::Units and Padding with a text input causes it to be bigger than Length::Units by Padding.

We need to apply pad to Limits AFTER width, otherwise width will set Limits back to a fixed width if Length::Units is used, overwriting padding.

@tarkah
Pad after setting width
a9992d1 
Otherwise `width` will set limits back to a fixed width if
`Length::Units` is used, overwriting padding.
@casperstorm
Copy link
Member

Good catch 👍🏻

@hecrj hecrj added bug Something isn't working widget layout labels Feb 15, 2023
@hecrj hecrj added this to the 0.8.0 milestone Feb 15, 2023
hecrj
hecrj approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hecrj hecrj merged commit 0cb72f6 into iced-rs:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working layout widget
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tarkah @casperstorm @hecrj