Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require Copy for text StyleSheet::Style #1814

Merged
merged 1 commit into from
Apr 28, 2023

Commits on Apr 28, 2023

  1. Do not require Copy for text StyleSheet::Style

    For most widgets, `Style` only requires `Default`. A few require
    `Clone`. Only this one requires `Copy`.
    
    Some of the types in the default theme has a custom variant requiring
    `Box<dyn Trait>`, or `Rc<dyn Trait>` to provide `Clone`, but this isn't
    possible if `Copy` is required.
    
    It would be good to also address the inconsistency of requiring `Clone`
    in some places and not others.
    
    This removes `style/src/text.rs` which is unused in this branch and thus
    confusing. If there's a reason to keep it, that can be removed from the
    change.
    ids1024 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    47016a3 View commit details
    Browse the repository at this point in the history