Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition when growing an image::Atlas #1847

Merged
merged 2 commits into from
May 12, 2023

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented May 11, 2023

The CommandEncoder is used to copy the contents of the old layers to the new ones, but Queue was used to upload new allocations.

The fix consists in using CommandEncoder for all the atlas operations.

@hecrj hecrj added bug Something isn't working widget rendering image labels May 11, 2023
@hecrj hecrj added this to the 0.10.0 milestone May 11, 2023
@hecrj hecrj mentioned this pull request May 11, 2023
@hecrj hecrj merged commit 9706c99 into master May 12, 2023
@hecrj hecrj deleted the fix/image-atlas-race-condition branch May 12, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working image rendering widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant