Upgrade palette dependency
#1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
requested changes
May 25, 2023
core/src/color.rs
Outdated
Comment on lines
187
to
189
| impl From<Rgba> for Color { | ||
| fn from(rgba: Rgba) -> Self { | ||
| Color::new(rgba.red, rgba.green, rgba.blue, rgba.alpha) |
There was a problem hiding this comment.
Why has this been changed? Color is in the sRGB color space.
There was a problem hiding this comment.
Ah, I see. It's a type definition! Still, it seems more descriptive to use Srgb directly.
|
Thanks! Not sure what's up with CI. Let me take a look. |
hecrj
approved these changes
May 25, 2023
|
Sticking with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paletteto 0.7 across the libraryrgb::Rgbinstead ofSrgbdirectlyRelativeContrasttrait has been deprecated in favor ofcolor_difference::Wcag21RelativeContrastHue::to_positive_degrees()->Hue::into_positive_degrees()