-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add border_radius
to slider rail
#1892
Add border_radius
to slider rail
#1892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Can we make those sliders the default styling too? They look nice.
Changed it myself! I also fixed this rendering issue in 66d4dec: Apparently, our |
Small problem with 66d4dec is if the handle is very slim, say 1px. Then you see the rounding in the middle where the rectangles meet. |
I think if quad width is <= 2.0 we should not try to do a border radius, just use the normal quad border algorithm; border-radius of like 5 with a quad width of 2 doesn't make sense imo. Maybe just if quad width < border radius we render as a normal squared border? Or progressively shrink it until it's < 2.0 (in which case there will only be 1 px available for each corner)? |
@casperstorm Let's see how common that is. Maybe by the time someone complains we have already fixed the quad glitches. |
This small PR adds the ability to adjust the border radius for the slider rail.
I also updated the default colors of the rail slightly so it use two different colors rather than just one.