Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor availability #1904

Merged
merged 6 commits into from
Jun 9, 2023
Merged

Cursor availability #1904

merged 6 commits into from
Jun 9, 2023

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Jun 8, 2023 •
edited
Loading

This PR moves the canvas::Cursor type to the mouse module in the core crate and introduces it to the Widget and Overlay traits.

Until now, cursor availability was awkwardly encoded using a Point with -1.0 coordinates, which caused pesky bugs! These changes encode cursor availability in the type system and, therefore, widgets will need to handle the Unavailable case explicitly.

@hecrj hecrj added bug Something isn't working feature New feature or request widget labels Jun 8, 2023
@hecrj hecrj added this to the 0.10.0 milestone Jun 8, 2023
@hecrj hecrj merged commit 60cd864 into master Jun 9, 2023
@hecrj hecrj deleted the cursor-availability branch June 9, 2023 19:53
@tarkah tarkah mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working feature New feature or request widget
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@hecrj