Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ComboBox widget panic on wasm #2078

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Fix ComboBox widget panic on wasm #2078

merged 1 commit into from
Sep 10, 2023

Conversation

Nisatru
Copy link
Contributor

@Nisatru Nisatru commented Sep 10, 2023

The ComboBox widget always uses std::time::Instant which panics on Wasm.

-> switch to crate::core::time::Instant

@hecrj hecrj added this to the 0.12 milestone Sep 10, 2023
hecrj
hecrj approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@hecrj hecrj merged commit 4fe69c8 into iced-rs:master Sep 10, 2023
12 checks passed
@Nisatru Nisatru deleted the fix-combo-box branch September 11, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
fix web widget
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@Nisatru @hecrj