TextEditor widget (or multi-line text input)
#2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
changed the title
TextEditor widget or multi-line text inputTextEditor widget (or multi-line text input)
blazra
reviewed
Oct 27, 2023
widget/src/text_editor.rs
Outdated
| } | ||
| } | ||
| mouse::ScrollDelta::Pixels { y, .. } => { | ||
| -y.signum() as i32 |
There was a problem hiding this comment.
Scrolling behavior with touchpad is weird. If you scroll slowly it actually scrolls more lines more quickly than if you scroll a lot.
Because the editor scrolls by whole lines, I think you will need to keep some state like "fraction of a line already scrolled" to add it to the scroll distance on the next event. Or something like that.
Closed
|
"TextEditor is cumbersome to use. I only need a multiline input, not a text editor. Is there a simpler solution?" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a multi-line text input widget called
TextEditor.A
TextEditorcan be created with someContentand produces anActionwhen the user interacts with it. ThisActioncan be performed on theContentduringupdateto apply any cursor movements, clicks, and edits.A
TextEditoruses the newtext::HighlighterAPI to potentially highlight text. A new subcrateiced_highlightercontains a new basic syntax highlighter implementation on top ofsyntect.A new
editorexample has been implemented which leverages theTextEditorto build a simple text editor program with syntax highlighting. The latest video-tutorial in theiced-rsYouTube channel walks through the creation of the example: https://www.youtube.com/watch?v=gcBJ7cPSALo