Fix text clipping #2154
Merged
Fix text clipping #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingun
reviewed
Dec 1, 2023
hecrj
force-pushed
the
fix/text-clipping
branch
from
bf335d8
to
3504796
Compare
hecrj
force-pushed
the
fix/text-clipping
branch
from
3504796
to
b526ce4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple issues related to text rendering and layouting:
viewportbounds are used instead.Since widgets can now control the clipping viewport when drawing text, the
text_inputwidget does not need to issue a new rendering layer when horizontal scrolling is needed.Additionally, the
container,column, androwwidgets will only draw its contents when they are actually visible.