Use core::ptr::eq to speed up PartialEq on image::Bytes
#2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
force-pushed
the
faster_image_bytes_handle
branch
from
0e2665d
to
d6aea09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When loading images from memory
icedtakes a long time comparingimage::Handles.To improve its speed using
core::ptr::eqchecks if the slices are identical both the start pointer and the length.Effectiveness
I have not seen the optimization happen in either the standard library nor the results given by the compiler.
I also think I have seen the cost of
image::Handle's comparison in someperfdata.