Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clip property to Container, Column, Row, and Button #2252

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Feb 15, 2024

This PR makes clipping the contents of a container opt-in, which should help with text being cut-off by default when line height isn't high enough.

@hecrj hecrj added this to the 0.12 milestone Feb 15, 2024
@hecrj hecrj enabled auto-merge February 15, 2024 00:30
@hecrj hecrj changed the title Add clip property to Container, Column, and Row Add clip property to Container, Column, Row, and Button Feb 15, 2024
@hecrj hecrj merged commit 5827023 into master Feb 15, 2024
26 checks passed
@hecrj hecrj deleted the feature/clip-property branch February 15, 2024 00:48
@GyulyVGC
Copy link
Contributor

GyulyVGC commented Mar 7, 2024

Being false the default does this mean that Text shouldn't be cut-off when line height is not suitable?

Since 0.10 I've experienced some texts vanishing and I was only able to solve the problem by decreasing the line height of the corresponding text.
Not increasing, but decreasing.
And this is still true after this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants