Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text::Wrapping support #2279

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Add text::Wrapping support #2279

merged 3 commits into from
Sep 4, 2024

Conversation

nrjais
Copy link
Contributor

@nrjais nrjais commented Feb 21, 2024

This exposes wrapping strategy for text widget. I have kept the default to Wrapping::Word which it was in cosmic_text,
There are other widgets which are using text, I am not sure if Wrapping should be exposed there.

Sample
image

core/src/text.rs Outdated Show resolved Hide resolved
core/src/widget/text.rs Outdated Show resolved Hide resolved
@habics
Copy link

habics commented Feb 27, 2024

Hi, will this be available for TextEditor widget too or only for Text widget #2291

@habics
Copy link

habics commented Feb 27, 2024

Please consider adding this feature to TextEditor widget too

@nrjais
Copy link
Contributor Author

nrjais commented Feb 27, 2024

Added for text editor also

@nrjais nrjais force-pushed the wrapping branch 2 times, most recently from 139c9b8 to 48c19c9 Compare March 8, 2024 16:19
@nrjais
Copy link
Contributor Author

nrjais commented Mar 9, 2024

Rebased for latest theme changes

Co-authored-by: Neeraj Jaiswal <neerajj85@gmail.com>
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@hecrj hecrj enabled auto-merge September 4, 2024 19:30
@hecrj hecrj merged commit 6009420 into iced-rs:master Sep 4, 2024
12 checks passed
@nrjais nrjais deleted the wrapping branch September 4, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants