-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some text_editor QoL #2358
Some text_editor QoL #2358
Conversation
Word wrapping issue: word_wrapping.mov(Issue is known: pop-os/cosmic-text#219) After explicitly changing the wrap mode to "Glyph" we no longer overflow text buffer bounds in certain cases. glyph_wrapping.movI believe this is better than using |
b18c7f4
to
846791e
Compare
How does Wrap::Glyph wrap a normal sentence? Doesn't it just break the last word? |
It seems a fix may have been released in the latest I plan to update soon. |
846791e
to
385a449
Compare
I've reverted the last commit, just now just exposing those two methods 👍 Hopefully this is fixed in cosmic-text! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🥳
text_size
&line_height
fields inTextEditor
Wrap::Word
which will not fall back to glyph in cases of very long words