Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check is_secure before a copy/cut from TextInput #2366

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Check is_secure before a copy/cut from TextInput #2366

merged 2 commits into from
Apr 2, 2024

Conversation

Aaron-McGuire
Copy link
Contributor

@Aaron-McGuire Aaron-McGuire commented Apr 2, 2024 •
edited by hecrj
Loading

This PR adds a check for TextInput's is_secure value before copying or cutting from the field.

Fixes #2347.

@hecrj hecrj added this to the 0.13 milestone Apr 2, 2024
@hecrj hecrj added bug Something isn't working widget fix labels Apr 2, 2024
hecrj
hecrj approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. Thanks! 🎉

@hecrj hecrj enabled auto-merge (squash) April 2, 2024 08:39
@hecrj hecrj merged commit 31d1d5f into iced-rs:master Apr 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working fix widget
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.

Input widget should not copy or cut if secure
2 participants
@Aaron-McGuire @hecrj