Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra Download struct from dowload_progress example #2380

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

alex-ds13
Copy link
Contributor

I've just noticed that on the download_progress example there is an extra Download struct on the download.rs file that is not being used. For some reason, rust_analyzer doesn't give any warnings not even clippy. But that struct has no references to it.

I guess that it might have first been created to be used to pass the id and url from main to the download::file function, but then it ended up passing both parameters instead.

I don't know why didn't rust_analyzer pick this up before, but I tried running the example without it and it runs just fine. So might as well remove it so people don't confuse it with the actual Download struct that is created on the main.rs file.

@hecrj hecrj added this to the 0.13 milestone Apr 9, 2024
@hecrj hecrj added improvement An internal improvement subscription change labels Apr 9, 2024
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇

@hecrj hecrj enabled auto-merge April 9, 2024 20:33
@hecrj hecrj merged commit ee105e3 into iced-rs:master Apr 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants