-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved architecture for iced_wgpu
and iced_tiny_skia
#2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to AA, it's very expensive to render every cached layer independently.
hecrj
added
improvement
An internal improvement
feature
New feature or request
performance
rendering
wgpu
change
addition
labels
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
addition
change
feature
New feature or request
improvement
An internal improvement
performance
rendering
wgpu
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely rewrites the internals of both
iced_wgpu
andiced_tiny_skia
—all while removing a bunch of indirection, simplifying the layering logic, and introducing smarter caching.The
Backend
traits iniced_graphics
have been removed, together with thePrimitive
enum. Instead, renderers simply implement theRenderer
traits fromiced_core
directly. Layering logic is reused by leveraging the newLayer
trait andlayer::Stack
data structure iniced_graphics
.Therefore—instead of recording a primitive tree first and then flattening it as different layers—renderers now are capable of organizing graphical primitives in different layers while these primitives themselves are being recorded (during
Widget::draw
). Allocations are easily reused this way and, since there is no recursive data structure, we can avoid boxing altogether.Furthermore, the explicit layer-oriented architecture—as opposed to a primitive-oriented one—allows us to implement smarter caching strategies. Specifically, every
canvas::Cache
is now capable of caching—not only the tessellated vertices—but also the GPU vertex buffers and texture atlases directly. This effectively means we can avoid preparing and uploading vertex data every frame—specially useful if you are rendering a lot of text in aCanvas
!I took these changes as an opportunity to start benchmarking parts of the library and created a basic
wgpu
benchmark for now. It just draws 1000 rectangles and 1000 text sections offscreen using aCanvas
. When compared withmaster
, we can observe quite the speedup:Finally, these changes also introduce a new
Engine
type iniced_wgpu
that contains all the pipeline state (as well as the MSAA framebuffer). This type is shared between all the differentRenderer
instances; reducing the memory usage when using the multi-window feature considerably.