Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for explicit Length in center_* methods #2441

Merged
merged 1 commit into from
May 13, 2024

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented May 13, 2024

This removes some weird order-dependent behavior where calling center_* after width or height would override the set dimensions. Furthermore, it makes setting the dimensions actually explicit; since centering in a Shrink dimension is rarely useful.

@hecrj hecrj added this to the 0.13 milestone May 13, 2024
@hecrj hecrj enabled auto-merge May 13, 2024 16:46
@hecrj hecrj merged commit e69e2c0 into master May 13, 2024
24 checks passed
@hecrj hecrj deleted the feature/explicit-length-in-center-methods branch May 13, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant