Add on_press_with method for Button
#2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using a closure to produce the message only when the `Button` is actually pressed. Useful when generating the message may be expensive.
hecrj
force-pushed
the
button-on-press-with
branch
from
3a772e7 to
97e35f7
Compare
|
I think this can help with relaxing the clone requirement on the Message, If the current |
|
I don't see the point in adding an unnecessary heap allocation. Messages should be cloneable and other widgets demand that bound as well, like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using a closure to produce the message only when the
Buttonis actually pressed. Useful when generating the message may be expensive.