Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl Clone and Copy for all Style types in iced_style #720

Merged
merged 1 commit into from
Jan 29, 2021
Merged

impl Clone and Copy for all Style types in iced_style #720

merged 1 commit into from
Jan 29, 2021

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Jan 29, 2021

Many of the Style types in iced_style implement these traits, which is useful. It would be nice if the rest of the Style types in iced_style also have implementations of these traits.

hecrj
hecrj approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! We should always try to implement these traits.

Thanks 🥳

@hecrj hecrj added the feature New feature or request label Jan 29, 2021
@hecrj hecrj added this to the 0.3.0 milestone Jan 29, 2021
@hecrj hecrj merged commit 12c0c18 into iced-rs:master Jan 29, 2021
@taiki-e taiki-e deleted the style-clone branch January 29, 2021 18:57
@hecrj hecrj mentioned this pull request Mar 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @hecrj