Eslint #2
Merged
Eslint #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autofix is disabled for the moment as it causes issues with VS Code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the README notes:
JS code in your source paths will be linted using eslint. We use the base config from create-react-app, which is released as a separate package called eslint-config-react-app, and then add some small adjustments in each environment:
In development, we include prettier to enforce a code style across our projects. It’s recommended you add integration with your editor in some way so that you don’t get annoyed by all the errors. Ideally this formatting happens for us as part of the build, but this feature is disabled at the moment due to an issue with Visual Studio Code.
In production, we do not include prettier so it will not break your builds. We do however add a
no-debuggerrule to ensure that you can’t push production code that includes debugging lines.