Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row selection checkbox not highlighted V7 #464

Closed
icflorescu opened this issue Nov 8, 2023 Discussed in #463 · 0 comments
Closed

Row selection checkbox not highlighted V7 #464

icflorescu opened this issue Nov 8, 2023 Discussed in #463 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@icflorescu
Copy link
Owner

Discussed in #463

Originally posted by chrisbekas November 8, 2023
Clicking a row selection checkbox in V7 does not highlight the checkbox background like it did in V6 (which I quite liked!).

Is there a way to have that behave like it did in V6? Thank you!

Not as straightforward to implement as it used to be in V6 because of the new Mantine styling internals.

Here's why:

To respect the Mantine theme, I'm using var(--mantine-primary-color-light) as selection highlight color on cells (s), which is a transparent shade (of blue in the default theme).

However, I have to override the selection cell () background and set it to inherit the parent row color, because if I don't, I'd end with something like this when the table is horizontally scrolled:

image

Which is obviously not ok.

Actually, the same issue affects the last column when using the new pinLastColumn feature.

There might be a way to fix this by adding a pseudo-element on top of it (but behind the checkbox).

@icflorescu icflorescu self-assigned this Nov 8, 2023
@icflorescu icflorescu added the enhancement New feature or request label Nov 8, 2023
icflorescu added a commit that referenced this issue Nov 8, 2023
icflorescu added a commit that referenced this issue Nov 8, 2023
Fix #464 and #465, remove unused CSS selector, update changelog, bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant