Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 2 #115

Closed
wants to merge 2 commits into from
Closed

Patch 2 #115

wants to merge 2 commits into from

Conversation

pronotfound
Copy link

Refactored the SerializerRegistry class to properly handle serialization and deserialization of various data types using NBT elements.
Added the initialization call to SerializerRegistry.initialize() in the FactionsMod main mod class to ensure the serializer registry is set up when the mod is initialized.

Copy link
Collaborator

@BlueZeeKing BlueZeeKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are build errors in this code. Also, I saw your post on discord, and I don't see how this fixes anything related to an issue with the enchantment registry.

@BlueZeeKing
Copy link
Collaborator

The static block should work fine for this. Why did you switch to using an initialize method?

@BlueZeeKing
Copy link
Collaborator

This bug is fixed in bdd67b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants