BROKEN Use sparse set for UI node extraction #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicopap
changed the title
|
This is currently unworkable due to text glyphs each having an individual |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks UI borders, so don't merge yet
This is a less complex change that happens to be much faster than the
Drainiterator.However, this is incompatible with the pattern of pushing one
ExtractedUiNodeper border, so it can only be merged once bevyengine#8973 itself is merged firstSo without borders in the
many_buttonsstress test:prepare_uinodeis twice as fast as your current change (I suppose this makes it a ×8 speedup from bevy/main)Extractschedule is 30% faster (due toextract_uinodes*systems being faster)