Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 77 user story channel Implementing openack handshake #203

Merged

Conversation

shanithkk
Copy link
Collaborator

Description:

As an application developer, I want to implement the OpenACK handshake protocol for a communication channel so that I can ensure reliable and secure message delivery. The protocol involves a series of steps that ensure that messages are transmitted and received in a secure and reliable manner.

Commit Message

feat: Implementing openack handshake  for channel

see the guidelines for commit messages.

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Merging #203 (97e8180) into main (20f16d3) will increase coverage by 0.99%.
The diff coverage is 81.34%.

@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   56.74%   57.74%   +0.99%     
==========================================
  Files          68       68              
  Lines        6312     6562     +250     
==========================================
+ Hits         3582     3789     +207     
- Misses       2730     2773      +43     
Impacted Files Coverage Δ
contracts/cosmwasm-vm/cw-ibc-core/src/msg.rs 94.38% <ø> (ø)
.../cw-ibc-core/src/ics04_channel/handler/open_ack.rs 73.27% <73.27%> (ø)
...smwasm-vm/cw-ibc-core/src/ics04_channel/handler.rs 73.89% <86.42%> (+5.91%) ⬆️
...osmwasm-vm/cw-ibc-core/src/ics04_channel/events.rs 98.88% <100.00%> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shreyasbhat0 shreyasbhat0 merged commit 697a59d into main Apr 4, 2023
@shreyasbhat0 shreyasbhat0 deleted the 77-user-story-channel-implementing-openack-handshake branch April 4, 2023 13:04
ibrizsabin pushed a commit that referenced this pull request Apr 4, 2023
* chore: Add test case for open ack handshake

* chore: fix clippy

* chore: update messages

---------

Co-authored-by: shreyasbhat0 <shreyas.ks@hugobyte.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants