Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adapt connection to xCall optimizations #571

Merged

Conversation

AntonAndell
Copy link
Collaborator

@AntonAndell AntonAndell commented Aug 2, 2023

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Merging #571 (cbeb9fc) into main (8b3dbac) will decrease coverage by 0.03%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #571      +/-   ##
============================================
- Coverage     62.77%   62.75%   -0.03%     
+ Complexity      404      402       -2     
============================================
  Files           156      156              
  Lines         14761    14755       -6     
  Branches        292      290       -2     
============================================
- Hits           9266     9259       -7     
- Misses         5339     5340       +1     
  Partials        156      156              
Flag Coverage Δ
java 79.88% <71.42%> (-0.12%) ⬇️
rust 60.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../main/java/ibc/xcall/connection/IBCConnection.java 88.20% <71.42%> (-0.93%) ⬇️

@AntonAndell AntonAndell force-pushed the feature/adapt-connections-to-xcall-optimization-update branch 2 times, most recently from cfcb6db to bf73815 Compare August 2, 2023 12:46
@AntonAndell AntonAndell closed this Aug 2, 2023
@AntonAndell AntonAndell reopened this Aug 2, 2023
@AntonAndell AntonAndell marked this pull request as ready for review August 2, 2023 12:46
@AntonAndell AntonAndell changed the title feat: Update IBC connection and e2e test case to work with newest xCa… feat: Adapt connection and e2e to xCall update Aug 2, 2023
@AntonAndell AntonAndell force-pushed the feature/adapt-connections-to-xcall-optimization-update branch from bf73815 to 62ec873 Compare August 2, 2023 13:48
@AntonAndell AntonAndell changed the title feat: Adapt connection and e2e to xCall update feat: Adapt connection to xCall optimizations Aug 2, 2023
Copy link
Collaborator

@redlarva redlarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@redlarva redlarva merged commit c55e948 into main Aug 3, 2023
@redlarva redlarva deleted the feature/adapt-connections-to-xcall-optimization-update branch August 3, 2023 04:59
@AntonAndell AntonAndell linked an issue Aug 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt IBC Connections to xCall optimization changes.
5 participants