Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Authenticate capability missing on Send packet method. #182 #643

Merged
merged 6 commits into from
Aug 24, 2023

Conversation

ibrizsabin
Copy link
Collaborator

@ibrizsabin ibrizsabin commented Aug 21, 2023

Description:

Commit Message

fix: Authenticate capability missing on Send packet method. #182

see the guidelines for commit messages.

Changelog Entry

0.1.0: Add Source Port Authentication on Send Packet

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@ibrizsabin ibrizsabin added Archway Archway Chain related task Audit Issue Issues discovered in security audit labels Aug 21, 2023
@ibrizsabin ibrizsabin self-assigned this Aug 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #643 (08ac72e) into main (c4eac8e) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #643   +/-   ##
=========================================
  Coverage     68.83%   68.84%           
  Complexity      404      404           
=========================================
  Files           151      151           
  Lines         14050    14056    +6     
  Branches        288      288           
=========================================
+ Hits           9672     9677    +5     
- Misses         4226     4227    +1     
  Partials        152      152           
Flag Coverage Δ
rust 66.88% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...w-ibc-core/src/ics04_channel/packet/send_packet.rs 74.13% <83.33%> (+0.50%) ⬆️
contracts/cosmwasm-vm/cw-ibc-core/src/contract.rs 46.19% <100.00%> (ø)

@ibrizsabin ibrizsabin requested a review from AntonAndell August 24, 2023 13:26
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AntonAndell AntonAndell merged commit ace5988 into main Aug 24, 2023
@AntonAndell AntonAndell deleted the fix/security-review-182 branch August 24, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Archway Archway Chain related task Audit Issue Issues discovered in security audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants