-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Authenticate capability missing on Send packet method. #182 #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrizsabin
added
Archway
Archway Chain related task
Audit Issue
Issues discovered in security audit
labels
Aug 21, 2023
ibrizsabin
requested review from
redlarva,
nightowl121 and
AntonAndell
as code owners
August 21, 2023 10:57
Codecov Report
@@ Coverage Diff @@
## main #643 +/- ##
=========================================
Coverage 68.83% 68.84%
Complexity 404 404
=========================================
Files 151 151
Lines 14050 14056 +6
Branches 288 288
=========================================
+ Hits 9672 9677 +5
- Misses 4226 4227 +1
Partials 152 152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AntonAndell
reviewed
Aug 21, 2023
…into fix/security-review-182
AntonAndell
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Commit Message
fix: Authenticate capability missing on Send packet method. #182
see the guidelines for commit messages.
Changelog Entry
Checklist: