-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor unnecessary replies #647
Conversation
Codecov Report
@@ Coverage Diff @@
## main #647 +/- ##
============================================
- Coverage 69.11% 69.06% -0.06%
+ Complexity 404 401 -3
============================================
Files 151 152 +1
Lines 14044 13770 -274
Branches 287 282 -5
============================================
- Hits 9707 9510 -197
+ Misses 4186 4112 -74
+ Partials 151 148 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Make sure to try and run the e2e for PRs like this to make sure the functionallity is the same |
…into fix/security-review-180-183-185
…into fix/security-review-180-183-185
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, with e2e passing it should be good to merge
Description:
Removed callback replies from cross contract calls since we found it to be unnecessary in most of the cases and also had probability of introducing reentrancy.
Commit Message
fix: removed unnecessary replies in cross contract calls to reduce reentrancy
see the guidelines for commit messages.
Changelog Entry
Checklist: