-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use consensus state and client state from lightclient 232 #670
Conversation
…into fix/security-review-180-183-185
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #670 +/- ##
============================================
- Coverage 68.95% 68.84% -0.11%
- Complexity 405 406 +1
============================================
Files 151 152 +1
Lines 13810 13863 +53
Branches 290 290
============================================
+ Hits 9522 9544 +22
- Misses 4136 4167 +31
Partials 152 152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…into fix/security-review-232
I am guessing the decrease in coverage comes from removal of code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks fine, approved if the E2E passes
* fix: fix tests * chore: pass build * fix: validate packet expiry * fix: add unit test for timeout * chore: pass build * fix: add test for packet timeout * chore: pass build * chore: remove cmnts * fix: fix validate packet expired * fix: timeout test * chore: build pass * fix: fix unit test * chore: pass build * fix: resolve conversation * fix: fix test * fix: timeout test * chore: pass build --------- Co-authored-by: sabinchitrakar <immortal.infidel@gmail.com>
* fix: get client type from client state * fix: rm log * fix: remove reply from create client * fix: update create client * fix: remove sending root * chore: build check * fix: store client id on update * fix: rename client * chore: pass build * fix: build script * fix: fix build --------- Co-authored-by: sabinchitrakar <immortal.infidel@gmail.com> Co-authored-by: redlarva <91685111+redlarva@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good and the end-to-end (e2e) run completed successfully.
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: