Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: additional checks added in configure connection #682

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

gcranju
Copy link
Collaborator

@gcranju gcranju commented Sep 1, 2023

Description:

Commit Message

fix: additional checks added in configure connection 

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@gcranju gcranju added Audit Issue Issues discovered in security audit Cosmwasm labels Sep 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Merging #682 (ac6209f) into main (e6d5089) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 42.85%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #682   +/-   ##
=========================================
  Coverage     69.03%   69.03%           
  Complexity      406      406           
=========================================
  Files           152      152           
  Lines         13836    13838    +2     
  Branches        290      291    +1     
=========================================
+ Hits           9551     9553    +2     
+ Misses         4133     4132    -1     
- Partials        152      153    +1     
Flag Coverage Δ
java 80.88% <0.00%> (-0.05%) ⬇️
rust 67.04% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../cosmwasm-vm/cw-common/src/xcall_connection_msg.rs 40.00% <ø> (ø)
.../main/java/ibc/xcall/connection/IBCConnection.java 87.89% <0.00%> (-0.47%) ⬇️
...osmwasm-vm/cw-xcall-ibc-connection/src/contract.rs 53.22% <40.00%> (-0.61%) ⬇️
...-xcall-ibc-connection/src/types/config_response.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@gcranju gcranju added the enhancement New feature or request label Sep 5, 2023
Copy link
Collaborator

@redlarva redlarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Collaborator

@ibrizsabin ibrizsabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ibrizsabin ibrizsabin merged commit a59ecbe into main Sep 7, 2023
15 of 16 checks passed
@ibrizsabin ibrizsabin deleted the 259-configure-connection-can-be-reset-by-admin branch September 7, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audit Issue Issues discovered in security audit Cosmwasm enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants