Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "private protected" support #1010

Merged
merged 18 commits into from
Dec 21, 2017
Merged

Conversation

pentp
Copy link
Contributor

@pentp pentp commented Dec 12, 2017

This fixes "private protected" display for C# 7.2.

@siegfriedpammer siegfriedpammer added this to the 3.1 milestone Dec 13, 2017
@siegfriedpammer
Copy link
Member

siegfriedpammer commented Dec 14, 2017

Thank you for you pull request, while the changes look quite good, we haven't yet decided how to deal with testing/implementing C# 7+ features, we now have to pull forward an internal architecture discussion. Please note this might take a while.

Note: before accepting your PR we would ask you to add some unit tests, but as mentioned above we haven't yet decided on how we want to handle testing multiple versions of Roslyn / language versions. So, currently adding unit tests would only break the build. We will update you as soon as we've implemented proper support for testing > C# 7.0 features.

@siegfriedpammer
Copy link
Member

Note: I will add some unit tests and then merge your PR.

@siegfriedpammer siegfriedpammer merged commit 4ed1531 into icsharpcode:master Dec 21, 2017
@siegfriedpammer
Copy link
Member

Thank you for your pull request!

@pentp pentp deleted the famandasm branch December 21, 2017 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants