Fix flushing GZipOutputStream so all data is written to the underlying stream #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When flushing a GZipOutputStream, ensure we deflate all data in the input buffer and write it to the underlying stream before we flush the underlying stream.
DeflaterEngine.DeflateStored would always write more output even if there was no more input data to write, resulting in an infinite loop.
piksel
approved these changes
Jul 1, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that when flushing a
GZipOutputStreamno data was not actually written to the underlying stream before it was flushed due to the!deflater_.IsNeedingInputcheck inDeflaterOutputStream.Deflate.This PR fixes that and a couple of other related issues I came across when testing:
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.